807 delete lapis 1 and clean up #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKellerer
force-pushed
the
807-delete-lapis-1-and-clean-up
branch
9 times, most recently
from
2d9fec1 to
6276687
Compare
fengelniederhammer
approved these changes
May 29, 2024
|
|
||
| on: [push] | ||
|
|
||
| env: | ||
| DOCKER_IMAGE_NAME: ghcr.io/genspectrum/lapis-v2-docs | ||
| DOCKER_IMAGE_NAME: ghcr.io/genspectrum/lapis-docs |
There was a problem hiding this comment.
I just noticed that the running mpox instance on s0 has its own branch (ghcr.io/genspectrum/lapis-docs:br-mpox is currently running).
But there is also still ghcr.io/genspectrum/lapis-docs:public running:
- Can we simply turn that off?
- Should we migrate that to the
lapis-v1tag?
Another thought on this: Do we still need the public branch?
There was a problem hiding this comment.
But there is also still ghcr.io/genspectrum/lapis-docs:public running:
I'd leave it for now and have another cleaning round when we take LAPIS 1 open fully offline.
And also add the |
JonasKellerer
force-pushed
the
807-delete-lapis-1-and-clean-up
branch
2 times, most recently
from
0ec961f to
4f5a153
Compare
- move lapis2 to lapis - move lapis2-docs to lapis-docs - move siloLapisTests to lapis-e2e
JonasKellerer
force-pushed
the
807-delete-lapis-1-and-clean-up
branch
from
4f5a153 to
3dbf6e8
Compare
fengelniederhammer
added a commit
to loculus-project/loculus
that referenced
this pull request
Jun 17, 2024
GenSpectrum/LAPIS#820 renamed the image
corneliusroemer
pushed a commit
to loculus-project/loculus
that referenced
this pull request
Jun 17, 2024
GenSpectrum/LAPIS#820 renamed the image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #807
Removes lapis 1 folders and renames lapis 2:
lapis2->lapislapis2-docs->lapis-docssiloLapisTests->lapis-e2eRenames docker images of lapis2
lapis-v2->lapislapis2-docs->lapis-docsThe previous docker image
lapis-docshas now a taglapis-v1, so it can still be used. The mpox instance already uses its own tag for the documentationpr-mpox.The README now has a general section in the base folder. For each folder there is a specific README. (Mostly copied over from the README in the lapis2 folder.
Necessary after merge:
lapisdocker image (0.2.2. and 0.2)PR Checklist
- [ ] All necessary documentation has been adapted.- [ ] The implemented feature is covered by an appropriate test.