Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

807 delete lapis 1 and clean up #820

Merged
merged 2 commits into from
Jun 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 3 additions & 3 deletions .commitlintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ const Configuration = {
RuleConfigSeverity.Error,
"always",
[
"lapis2",
"lapis2-docs",
"siloLapisTests",
"lapis",
"lapis-docs",
"lapis-e2e",
"github-actions",
"root", // used by dependabot to update the root package.json
]
Expand Down
12 changes: 6 additions & 6 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ updates:
commit-message:
prefix: "chore(github-actions)"
- package-ecosystem: gradle
directory: lapis2/
directory: lapis/
schedule:
interval: weekly
groups:
Expand All @@ -16,9 +16,9 @@ updates:
- "minor"
- "patch"
commit-message:
prefix: "chore(lapis2)"
prefix: "chore(lapis)"
- package-ecosystem: npm
directory: siloLapisTests/
directory: lapis-e2e/
schedule:
interval: weekly
groups:
Expand All @@ -27,9 +27,9 @@ updates:
- "minor"
- "patch"
commit-message:
prefix: "chore(siloLapisTests)"
prefix: "chore(lapis-e2e)"
- package-ecosystem: npm
directory: lapis2-docs/
directory: lapis-docs/
schedule:
interval: weekly
groups:
Expand All @@ -38,7 +38,7 @@ updates:
- "minor"
- "patch"
commit-message:
prefix: "chore(lapis2-docs)"
prefix: "chore(lapis-docs)"
- package-ecosystem: npm
directory: /
schedule:
Expand Down
38 changes: 0 additions & 38 deletions .github/workflows/docs_docker.yaml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: LAPIS v2 Docs
name: LAPIS Docs

on: [push]

env:
DOCKER_IMAGE_NAME: ghcr.io/genspectrum/lapis-v2-docs
DOCKER_IMAGE_NAME: ghcr.io/genspectrum/lapis-docs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that the running mpox instance on s0 has its own branch (ghcr.io/genspectrum/lapis-docs:br-mpox is currently running).

But there is also still ghcr.io/genspectrum/lapis-docs:public running:

  • Can we simply turn that off?
  • Should we migrate that to the lapis-v1 tag?

Another thought on this: Do we still need the public branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But there is also still ghcr.io/genspectrum/lapis-docs:public running:

I'd leave it for now and have another cleaning round when we take LAPIS 1 open fully offline.

defaults:
run:
working-directory: ./lapis2-docs
working-directory: ./lapis-docs

jobs:
checks:
Expand All @@ -21,7 +21,7 @@ jobs:
- uses: actions/cache@v4
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('lapis2-docs/**/package-lock.json') }}
key: ${{ runner.os }}-node-${{ hashFiles('lapis-docs/**/package-lock.json') }}
- run: npm ci
- run: npm run check-format
- run: npm run check-types
Expand Down Expand Up @@ -56,7 +56,7 @@ jobs:
- name: Build and push image
uses: docker/build-push-action@v5
with:
context: ./lapis2-docs
context: ./lapis-docs
push: true
tags: ${{ steps.dockerMetadata.outputs.tags }}

Expand Down Expand Up @@ -95,5 +95,5 @@ jobs:
if: ${{ failure() }}
with:
name: playwright-report
path: lapis2-docs/playwright-report/
path: lapis-docs/playwright-report/
retention-days: 7
38 changes: 19 additions & 19 deletions .github/workflows/lapis2.yml → .github/workflows/lapis.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: LAPIS v2
name: LAPIS

on: [ push ]

env:
DOCKER_IMAGE_NAME: ghcr.io/genspectrum/lapis-v2
DOCKER_IMAGE_NAME: ghcr.io/genspectrum/lapis

jobs:
Tests:
Expand All @@ -19,12 +19,12 @@ jobs:
uses: gradle/actions/setup-gradle@v3
with:
arguments: test
build-root-directory: lapis2
build-root-directory: lapis
- name: Check Format And Lint
uses: gradle/actions/setup-gradle@v3
with:
arguments: ktlintCheck
build-root-directory: lapis2
build-root-directory: lapis

dockerImage:
name: Build Docker Image
Expand Down Expand Up @@ -56,10 +56,10 @@ jobs:
- name: Build and push image
uses: docker/build-push-action@v5
with:
context: ./lapis2
context: ./lapis
tags: ${{ steps.dockerMetadata.outputs.tags }}
cache-from: type=gha,scope=lapis2-${{ github.ref }}
cache-to: type=gha,mode=max,scope=lapis2-${{ github.ref }}
cache-from: type=gha,scope=lapis-${{ github.ref }}
cache-to: type=gha,mode=max,scope=lapis-${{ github.ref }}
platforms: ${{ github.ref == 'refs/heads/main' && 'linux/amd64,linux/arm64' || 'linux/amd64' }}
push: true

Expand All @@ -83,35 +83,35 @@ jobs:
uses: gradle/actions/setup-gradle@v3
with:
arguments: generateOpenApiDocs
build-root-directory: lapis2
build-root-directory: lapis

- name: Build OpenAPI Spec Protected
uses: gradle/actions/setup-gradle@v3
with:
arguments: generateOpenApiDocs -PopennessLevel=protected
build-root-directory: lapis2
build-root-directory: lapis

- name: Cache .npm
uses: actions/cache@v4
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('siloLapisTests/**/package-lock.json') }}
key: ${{ runner.os }}-node-${{ hashFiles('lapis-e2e/**/package-lock.json') }}

- name: Prepare Tests
run: npm ci
working-directory: siloLapisTests
working-directory: lapis-e2e

- name: Generate Lapis Client
run: npm run generateLapisClient
working-directory: siloLapisTests
working-directory: lapis-e2e

- name: Generate Lapis Client Protected
run: npm run generateLapisClientProtected
working-directory: siloLapisTests
working-directory: lapis-e2e

- name: Check Format
run: npm run check-format
working-directory: siloLapisTests
working-directory: lapis-e2e

- name: Docker metadata
id: dockerMetadata
Expand All @@ -137,17 +137,17 @@ jobs:

- name: Start SILO and LAPIS and Run Tests
run: |
docker compose -f lapis2/docker-compose.yml pull
docker compose -f lapis2/docker-compose.yml up -d --wait
cd siloLapisTests && npm run test
docker compose -f lapis/docker-compose.yml pull
docker compose -f lapis/docker-compose.yml up -d --wait
cd lapis-e2e && npm run test
env:
SILO_TAG: latest
LAPIS_TAG: ${{ steps.lapisBranchTag.outputs.lapisTag }}

- name: Store Logs
if: ${{ always() }}
run: |
cd lapis2
cd lapis
mkdir p e2e-logs
docker compose logs silo > e2e-logs/silo.log
docker compose logs lapisOpen > e2e-logs/lapisOpen.log
Expand All @@ -161,4 +161,4 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: logs
path: lapis2/e2e-logs
path: lapis/e2e-logs
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
name: Release LAPIS 2
name: Release LAPIS

on:
workflow_run:
workflows: [LAPIS v2]
workflows: [LAPIS]
types: [completed]
branches: [main]

env:
LAPIS_DOCKER_IMAGE_NAME: ghcr.io/genspectrum/lapis-v2
DOCS_DOCKER_IMAGE_NAME: ghcr.io/genspectrum/lapis-v2-docs
LAPIS_DOCKER_IMAGE_NAME: ghcr.io/genspectrum/lapis
DOCS_DOCKER_IMAGE_NAME: ghcr.io/genspectrum/lapis-docs

jobs:
release-please:
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Wait for Lapis 2 Docs Docker Image
- name: Wait for Lapis Docs Docker Image
if: ${{ steps.release.outputs.release_created }}
uses: lewagon/[email protected]
with:
Expand Down
38 changes: 0 additions & 38 deletions .github/workflows/server_docker.yml

This file was deleted.

38 changes: 0 additions & 38 deletions .github/workflows/swagger_docker.yaml

This file was deleted.

36 changes: 0 additions & 36 deletions .github/workflows/test.yml

This file was deleted.

2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
# Personal preference
playground/

docker-compose.override.yml

log/
logs/

Expand Down
Loading
Loading