-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Proxy and cache avatar images #907
refactor: Proxy and cache avatar images #907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
bb5b51d
to
7e7a65c
Compare
No problem at all work's great ! |
374eaee
to
808e616
Compare
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
@JoaquinOlivero could you resolve the conflicts? So we can get this in EDIT: its okay I have done it c: |
722bf2b
to
b46d247
Compare
b46d247
to
1306a2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try to replace .startsWith('https://gravatar.com')
with .startsWith('https://gravatar.com/')
(note the /
at the end) to see if it fixes the GitHub security warnings?
d461189
to
e6e2523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not tested yet but LGTM
Could the action run for a docker image be done please ? |
Done with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some issues were reported (on issues index) in discord so until that is fixed
…plicates for different users
17e852e
to
c195a6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good!
🎉 This PR is included in version 2.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
This PR changes how Jellyseerr handles profile images. Now they are proxied from the source and cached in the disk.
The caching mechanism uses the already existing "ImageProxy" class which I tweaked.
Also, I added a new endpoint "/avatarproxy" that takes the URL from the images, caches them if needed, and then returns them.
Screenshot (if UI-related)
To-Dos
pnpm build
pnpm i18n:extract
Issues Fixed or Closed