feat: blacklist items from Discover page #632
Conversation
|
Is this PR complete? |
Yes, it's complete |
|
Then you should switch the PR from draft to Open ? |
Okay I'm switching it to ready for review and I'll review it sometime this weekend c: |
There was a problem hiding this comment.
Test it the only missing point is the translation keys but everything else works fine !
Edit : How can I remove a blacklisted media from blacklist ? @JoaquinOlivero
| <Modal | ||
| backgroundClickable | ||
| title={`Blacklist ${title}`} | ||
| subTitle="Are you sure you want to proceed?" |
There was a problem hiding this comment.
Could you add the translation key please ?
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
JoaquinOlivero
force-pushed
the
hide-items
branch
from
0b18995 to
7221671
Compare
github-actions
bot
removed
the
merge conflict
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
JoaquinOlivero
force-pushed
the
hide-items
branch
from
7221671 to
a05e4aa
Compare
github-actions
bot
removed
the
merge conflict
JoaquinOlivero
force-pushed
the
hide-items
branch
from
694be51 to
5590c63
Compare
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
Hello @JoaquinOlivero could you please solve the merge conflict when #907 is merged so I can test this pull request and it can get reviewed thanks! |
…from the blacklist
…ed. Also add a blacklist button
JoaquinOlivero
force-pushed
the
hide-items
branch
from
5590c63 to
6c6e395
Compare
github-actions
bot
removed
the
merge conflict
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@JoaquinOlivero My blacklist doesn't seem to act in the way your preview does. Blacklisted items still appear on the discover pages, unless you remove all blacklist permissions from a user. Am I missing something?
|
This is the intended behavior. Users with blacklist permissions can see and hide items so that regular users can't see these items anymore in the app. |
|
Understood. Even as an admin, I'd still quite like these hidden from discover pages. |
|
@oOStroudyOo see #1022 for this feature request |
* feat: blacklist media items re Fallenbagel#490 * feat: blacklist media items * feat: blacklist media items * style: formatting * refactor: close the manage slide-over when the media item is removed from the blacklist * fix: fix media data in the db when blacklisting an item * refactor: refactor component to accept show boolean * refactor: hide watchlist button in the media page when it's blacklisted. Also add a blacklist button * style: formatting --------- Co-authored-by: JoaquinOlivero <[email protected]>
* feat: blacklist media items re Fallenbagel#490 * feat: blacklist media items * feat: blacklist media items * style: formatting * refactor: close the manage slide-over when the media item is removed from the blacklist * fix: fix media data in the db when blacklisting an item * refactor: refactor component to accept show boolean * refactor: hide watchlist button in the media page when it's blacklisted. Also add a blacklist button * style: formatting --------- Co-authored-by: JoaquinOlivero <[email protected]>
[Feature Request] Hide Items #490
Description
Allow users with special permissions to add media items to a blacklist to prevent them from being displayed.
The blacklist can be managed on the "Settings" page where media can be removed from it. In addition, if the user has permission to manage and view blacklisted items, there is a button on the movie/series card to remove it from the blacklist.
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed