-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
37 create a basic intake subsystem #59
Conversation
…om/FRC-Team-620/Warbots2024 into 37-create-a-basic-intake-subsystem
Changed the IntakeCommand file with the information in last year's version. Added IntakeConstants file just to place contastant although can delete later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, have a few requests for changes though.
src/main/java/org/jmhsrobotics/frc2024/subsystems/drive/commands/IntakeConstants.java
Outdated
Show resolved
Hide resolved
protected Solenoid intakeArmsVirtualSolenoidB; | ||
protected CANSparkMax intakeArmsMotor; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our intake only will have a single motor. We probably will not have any pneumatics.
src/main/java/org/jmhsrobotics/frc2024/subsystems/drive/commands/IntakeCommand.java
Outdated
Show resolved
Hide resolved
protected Solenoid intakeArmsVirtualSolenoidB; | ||
protected CANSparkMax intakeArmsMotor; | ||
protected DigitalInput intakeSwitch; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use private access modifier.
Will probably need more changes but want to check the situation so far.