feat: enable bridgeless #48160

WoLewicki · 2024-08-28T10:55:04Z

Details

PR enabling bridgeless mode in the App. This PR can affects the App as a whole, so should require full regression testing.

PRs for introduced patches:

react-native-quick-sqlite: feat: remove usage of currentBridge margelo/react-native-quick-sqlite#64
react-native-pager-view: feat: remove usage of currentBridge callstack/react-native-pager-view#881
react-native-firebase: We have a dirty workaround and Meta is already working on a better solution after I reported the problem to them. We won't make a PR with it since it's better to wait for it to be fixed in core. (issue in RN repo: [New Architecture][iOS][Bridgeless] Native module methods not visible in JS facebook/react-native#46779)
lottie-react-native: The changes are already available on rc: feat: add experimental bridgeless support lottie-react-native/lottie-react-native#1160
rnmapbox/maps: fix: events in bridgeless mode rnmapbox/maps#3656
react-native-modal is not maintained from what I know and there are plans for providing our own, faster implementation of the library.
react-native-vision-camera: fix: events in bridgeless mode mrousavy/react-native-vision-camera#3240

Fixed Issues

$ #48163
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-10-04T13:02:27Z

@fedirjh @roryabraham One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-10-04T13:37:50Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/48160/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/48160/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48160/NewExpensify.dmg	https://48160.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

roryabraham · 2024-10-04T16:14:46Z

react-native-keyboard-controller: The code is already there from 1.13.0 so it just needs a bump and we can remove the patch then.

So let's do this before we merge this PR, rather than creating a patch that has to be cleaned up after

roryabraham · 2024-10-04T16:17:38Z

Created #50253

roryabraham · 2024-10-04T16:18:02Z

react-native-firebase: We have a dirty workaround and Meta is already working on a better solution after I reported the problem to them. We won't make a PR with it since it's better to wait for it to be fixed in core.

Can you link to an upstream issue plz? 🙇🏼

WoLewicki · 2024-10-07T11:39:52Z

Can you link to an upstream issue plz? 🙇🏼

Done.

fedirjh · 2024-10-07T14:23:48Z

@WoLewicki On iOS native, I cannot change the profile avatar or select an attachment in composer

CleanShot.2024-10-07.at.15.12.39.mp4

CleanShot.2024-10-07.at.14.56.32.mp4

When creating a distance request, the composer is shinking :

CleanShot.2024-10-07.at.15.09.10.mp4

I got the warning several times when I created a new expenses

fedirjh · 2024-10-07T15:12:39Z

@WoLewicki On android, when sending a new message, the app crashes with this error:

fedirjh · 2024-10-07T15:17:42Z

On Android: When you try to create a new expense, the App crashes with this error, there were other warnings errors as well :

fedirjh · 2024-10-07T15:22:06Z

On Android: When you create a scan expense, the App crashes with these errors:

fedirjh · 2024-10-07T15:43:23Z

When you navigate to troubleshoot page, the app will crash with this error :

WoLewicki · 2024-10-08T12:26:55Z

Seems like the event system on bridgeless mode on Android is far more strict regarding the event names. I'll fix those issues one by one, thanks @fedirjh !

github-actions · 2024-10-09T15:58:06Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Desktop build failed	The QR code can't be generated, because the web build failed

👀 View the workflow run that generated this build 👀

github-actions · 2024-10-10T08:46:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/48160/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/48160/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48160/NewExpensify.dmg	https://48160.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

hannojg · 2024-10-10T11:52:58Z

hey @WoLewicki will you open PR for all patches in the repositories upstream? I could help with the vision camera patch if you'd like to!

mountiny · 2024-10-10T12:04:11Z

@WoLewicki @hannojg yeah we should definitely try to follow up with those so we can keep track of all of the patches

WoLewicki · 2024-10-10T12:11:07Z

Yeah, sure I'll do. Thanks @hannojg , will ping you with any problems 😅 Also, is there a reason why you didn't modify all the needed places for onClear callback in RN core patch? I mean this one with the changes I needed to add: https://github.com/Expensify/App/pull/48160/files#diff-6220375a6bf22d664fd3eb2f7b023728fc40b97934d8731328aca0efadaee0b9. Or was it just an overlook?

hannojg · 2024-10-10T12:27:49Z

Also, is there a reason why you didn't modify all the needed places for onClear callback in RN core patch?

Is it missing in some of the view components javascript spec? i might have skipped doing that, due to the behaviour of w/o bridgeless reading it from the view manager. If so, feel free to add it everywhere necessary, yes!

WoLewicki · 2024-10-10T12:42:07Z

Ok, I did extend your patch already, thanks for clarification!

WoLewicki · 2024-10-11T13:57:11Z

@hannojg here is the PR to react-native-vision-camera: mrousavy/react-native-vision-camera#3240. It works on old arch, and I tried to test it on new arch, but the example app does not compile there 😞

hannojg · 2024-10-11T14:01:01Z

Nw, i will test the PR (probably going to merge it and then add anything else necessary to make new arch work, so nw, i am gonna take it from there 😊 👍 )

mountiny · 2024-10-14T03:33:06Z

@WoLewicki how is this looking, should I create a new build and should Fedi do another round of testing or should we wait for a bit?

WoLewicki · 2024-10-14T07:53:22Z

Let's do another build @mountiny, it should be ready for testing.

mountiny · 2024-10-14T08:59:10Z

New build running here

github-actions · 2024-10-14T09:27:28Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/48160/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/48160/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48160/NewExpensify.dmg	https://48160.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

fedirjh · 2024-10-14T10:30:48Z

@WoLewicki It tests well on iOS and Android 🚀 . Only still getting this warning on iOS :

WoLewicki · 2024-10-14T10:47:42Z

@fedirjh hmm I don't know where it can come from. But at the same time it does not change anything in how the app is working yes?

fedirjh · 2024-10-14T10:52:23Z

But at the same time it does not change anything in how the app is working yes?

Yes the app is still working as expected.

fedirjh · 2024-10-14T11:00:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

CleanShot.2024-10-14.at.10.55.19-trimmed.mp4

Android: mWeb Chrome

iOS: Native

CleanShot.2024-10-14.at.11.24.01.mp4

iOS: mWeb Safari

CleanShot.2024-10-14.at.11.34.34.mp4

MacOS: Chrome / Safari

MacOS: Desktop

fedirjh

LGTM

mountiny · 2024-10-18T04:02:38Z

@WoLewicki Are there some performance benefits we could already measure and expect from this PR?

WoLewicki · 2024-10-18T11:41:04Z

I tried to look at the output of Reassure Performance Tests job from this PR but I cannot find the results for the most interesting metric for us, being some kind of app TTI. Should I look somewhere else for it? I would restrain from getting those locally.

hannojg · 2024-10-18T12:49:10Z

@mountiny we could run the e2e tests, that gives us many interesting numbers (TTIs, FPS, Memory, CPU etc)

WoLewicki · 2024-10-18T13:09:00Z

I wouldn't expect enormous gains, but some at least due to Static View Configs.

feat: enable bridgeless

e7c526e

mountiny added the Ready To Build label Aug 28, 2024

mountiny assigned WoLewicki Aug 28, 2024

mountiny self-requested a review August 28, 2024 11:39

This comment has been minimized.

Sign in to view

j-piasecki and others added 6 commits September 20, 2024 13:39

Merge branch 'main' into @wolewicki/enable-bridgeless

f35a62d

Merge branch 'main' into @wolewicki/enable-bridgeless

972716b

fix: make ios work properly

23984a6

fix: make bridgeless work on Android

815041f

chore: revert rnconfig patch from this pr

ce7ce2c

Merge branch 'main' into @wolewicki/enable-bridgeless

5d70325

WoLewicki marked this pull request as ready for review October 4, 2024 13:02

WoLewicki requested a review from a team as a code owner October 4, 2024 13:02

melvin-bot bot requested review from fedirjh and roryabraham and removed request for a team October 4, 2024 13:02

roryabraham mentioned this pull request Oct 4, 2024

[HOLD for payment 2024-10-16] Bump react-native-keyboard-controller #50253

Closed

WoLewicki added 2 commits October 7, 2024 14:07

Merge branch 'main' into @wolewicki/enable-bridgeless

e1157c6

chore: merge current main

effd960

fix: add patches for events on Android

691ddc9

WoLewicki added 2 commits October 10, 2024 09:43

Merge branch 'main' into @wolewicki/enable-bridgeless

f900044

fix: patch for lottie

8ae48ee

fix: patch for react-native-modal on ios

52a976a

hannojg mentioned this pull request Oct 11, 2024

[HOLD App#48160] [$250] Request money component is jumpy when entering the digits #19961

Open

6 tasks

hannojg mentioned this pull request Oct 11, 2024

Update react-native-vision-camera to the latest version #50650

Open

WoLewicki mentioned this pull request Oct 11, 2024

Enable Bridgeless mode #48163

Open

fedirjh approved these changes Oct 14, 2024

View reviewed changes

feat: enable bridgeless #48160

Are you sure you want to change the base?

feat: enable bridgeless #48160

Conversation

WoLewicki commented Aug 28, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

This comment has been minimized.

melvin-bot bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

roryabraham commented Oct 4, 2024 • edited Loading

roryabraham commented Oct 4, 2024

roryabraham commented Oct 4, 2024

WoLewicki commented Oct 7, 2024

fedirjh commented Oct 7, 2024

fedirjh commented Oct 7, 2024

fedirjh commented Oct 7, 2024 • edited Loading

fedirjh commented Oct 7, 2024

fedirjh commented Oct 7, 2024

WoLewicki commented Oct 8, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 10, 2024

hannojg commented Oct 10, 2024

mountiny commented Oct 10, 2024

WoLewicki commented Oct 10, 2024

hannojg commented Oct 10, 2024 • edited Loading

WoLewicki commented Oct 10, 2024

WoLewicki commented Oct 11, 2024

hannojg commented Oct 11, 2024

mountiny commented Oct 14, 2024

WoLewicki commented Oct 14, 2024

mountiny commented Oct 14, 2024

github-actions bot commented Oct 14, 2024

fedirjh commented Oct 14, 2024

WoLewicki commented Oct 14, 2024

fedirjh commented Oct 14, 2024

fedirjh commented Oct 14, 2024

Reviewer Checklist

Screenshots/Videos

fedirjh left a comment

Choose a reason for hiding this comment

mountiny commented Oct 18, 2024

WoLewicki commented Oct 18, 2024

hannojg commented Oct 18, 2024

WoLewicki commented Oct 18, 2024

WoLewicki commented Aug 28, 2024 •

edited

Loading

roryabraham commented Oct 4, 2024 •

edited

Loading

fedirjh commented Oct 7, 2024 •

edited

Loading

hannojg commented Oct 10, 2024 •

edited

Loading