Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-16] Bump react-native-keyboard-controller #50253

Closed
roryabraham opened this issue Oct 4, 2024 · 7 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2

Comments

@roryabraham
Copy link
Contributor

Stemming off of #48160, we need to bump react-native-keyboard-controller to make it compatible with bridgeless mode. So let's bump the version first rather than adding a patch and cleaning up later.

@roryabraham
Copy link
Contributor Author

Asked the maintainers if they want to do this: https://expensify.slack.com/archives/C035J5C9FAP/p1728058626405019

@kirillzyusko
Copy link
Contributor

Hey, Kiryl from Margelo is here 👋

I'll handle this!

@kirillzyusko
Copy link
Contributor

Opened a PR here: #50325

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 9, 2024
@melvin-bot melvin-bot bot changed the title Bump react-native-keyboard-controller [HOLD for payment 2024-10-16] Bump react-native-keyboard-controller Oct 9, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 9, 2024
Copy link

melvin-bot bot commented Oct 9, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 9, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.46-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-16. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 16, 2024
Copy link

melvin-bot bot commented Oct 16, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@mountiny
Copy link
Contributor

No need for payment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants