Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Bridgeless mode #48163

Open
mountiny opened this issue Aug 28, 2024 · 10 comments
Open

Enable Bridgeless mode #48163

mountiny opened this issue Aug 28, 2024 · 10 comments
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

Problem

We have updated the app to the 0.75 RN version now which allows us to use bridgeless mode. You can read more about what this mode is here. We have not enabled it yet, though, so we are missing out on the benefits that this mode brings. The main benefit should be improved performance, although we still need to test and measure how much performance gains there are for us in the App.

Solution

Enable the Bridgeless mode in the App and compare the performance with the mode on and off

@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 28, 2024
Copy link

melvin-bot bot commented Aug 28, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mountiny mountiny added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Aug 28, 2024
Copy link

melvin-bot bot commented Aug 28, 2024

Current assignee @abekkala is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 28, 2024
@roryabraham
Copy link
Contributor

thanks for creating this @mountiny!

@melvin-bot melvin-bot bot added the Overdue label Sep 6, 2024
@mountiny
Copy link
Contributor Author

mountiny commented Sep 9, 2024

This will take some time to enable, swm is working on this

@melvin-bot melvin-bot bot removed the Overdue label Sep 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 17, 2024
@mountiny
Copy link
Contributor Author

We will want to post a proper problem solution to the channel before we make more progress on this one @WoLewicki @j-piasecki I will try to see if I can help with that

@melvin-bot melvin-bot bot removed the Overdue label Sep 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2024
@mountiny
Copy link
Contributor Author

updated proposal was shared in slack and I think we are good to move forward https://expensify.slack.com/archives/C05LX9D6E07/p1727354565454709

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Weekly KSv2 labels Sep 27, 2024
@roryabraham roryabraham removed their assignment Oct 4, 2024
@abekkala
Copy link
Contributor

@mountiny is there a PR for this one yet?

I'm going ooo until Oct 20 - I'd like to assign a buddy to watch this one until I return. But I'd like to better understand the progress status of this one first.

@WoLewicki
Copy link
Contributor

Here it is: #48160

@abekkala
Copy link
Contributor

Thank you for linking it @WoLewicki ! 🎉

@abekkala
Copy link
Contributor

cc: @OfstadC if this gets deployed to production soon and payment date is before Oct 21 here is the summary:

PAYMENT SUMMARY [date: TBD]:

  • Fix: @WoLewicki SoftwareMansion, no upwork payment needed
  • PR Review: @fedirjh [$250, if no regressions] payment is done via NewDot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Development

No branches or pull requests

5 participants