Revert "Merge pull request #12648 from margelo/@thomas/fast-image-cac… #13010

thomas-coldwell · 2022-11-24T17:31:28Z

This reverts commit 360a167, reversing changes made to 39a68d1.

Details

Reverting #12648

Fixed Issues

$ #13002

Tests

Ran the app on the Android emulator
Opened a chat, attached and sent a PDF file
Verified it does render the PDF thumbnail preview image correctly

Offline tests

QA Steps

Open up any chat
Attach and send a PDF
It should display "Uploading file..." for a short amount of time before correctly showing a preview thumbnail of the PDF file that was uploaded
Verify that reloading and returning to the chat does present this PDF preview as it was in step 3.

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots/Videos

Web

Screen.Recording.2022-11-24.at.18.52.22.mov

Mobile Web - Chrome

Screen.Recording.2022-11-24.at.19.09.39.mov

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2022-11-24.at.19.11.08.mp4

Desktop

Screen.Recording.2022-11-24.at.19.21.39.mov

iOS

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2022-11-24.at.19.11.08.mp4

Android

Screen.Recording.2022-11-24.at.18.44.23.mov

…image-caching" This reverts commit 360a167, reversing changes made to 39a68d1.

melvin-bot · 2022-11-24T17:32:00Z

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2022-11-24T17:36:05Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

luacmartins · 2022-11-24T17:43:08Z

I'll work on the checklist once @thomas-coldwell updates the OP with test steps and the screenshots/videos

thomas-coldwell · 2022-11-24T18:31:27Z

Updated, however, I have noticed a bug on Android mWeb (Chrome) that is visible in this screen recording - when attaching a PDF the preview in the modal causes the browser to completely freeze up 😬 I don't think this is related to the changes being reverted in this PR, but I will check out the commit the original PR was started from to see if the issue definitely existed prior. I also happened to have Flipper open at the same time that caught these logs from the device - looks like an internal Skia issue either with the emulators browser rendering engine or being caused by the react-pdf library:

Screen.Recording.2022-11-24.at.18.56.34.mov

Emulator Chrome Details:

thomas-coldwell · 2022-11-24T18:53:06Z

Checked on a physical device (OnePlus 6, Android 11, Chrome version 107.0.5304.105) and it works as expected:
https://user-images.githubusercontent.com/31568400/203850443-c2b19249-2cb9-473d-b308-50ebe86158cf.mp4

luacmartins · 2022-11-24T19:26:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

![chrome](https://user-images.githubusercontent.com/22219519/203855189-c5119adb-ddae-4020-961c-35a6ec3d2f83.png)

Mobile Web - Safari

Desktop

iOS

Android

![android](https://user-images.githubusercontent.com/22219519/203855242-7869a86c-e85b-48ae-8bed-56c2563fd8cb.png)

melvin-bot · 2022-11-24T19:41:12Z

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

luacmartins · 2022-11-24T19:42:01Z

Tests passed, not an emergency.

Revert "Merge pull request #12648 from margelo/@thomas/fast-image-cac… (cherry picked from commit 01abc6f)

…-13010 🍒 Cherry pick PR #13010 to staging 🍒

OSBotify · 2022-11-24T21:56:09Z

🚀 Cherry-picked to staging by @luacmartins in version: 1.2.31-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

luacmartins · 2022-12-06T17:40:04Z

The production deploy comment failed for this PR, but this was deployed to production on v1.2.32-2 on Nov 28.

OSBotify · 2023-06-15T01:40:40Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:58:24Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Revert "Merge pull request Expensify#12648 from margelo/@thomas/fast-…

94a90e1

…image-caching" This reverts commit 360a167, reversing changes made to 39a68d1.

thomas-coldwell requested a review from a team as a code owner November 24, 2022 17:31

melvin-bot bot requested review from nkuoch and removed request for a team November 24, 2022 17:31

mountiny assigned thomas-coldwell Nov 24, 2022

mountiny requested a review from luacmartins November 24, 2022 17:33

luacmartins added the CP Staging label Nov 24, 2022

luacmartins approved these changes Nov 24, 2022

View reviewed changes

luacmartins merged commit 01abc6f into Expensify:main Nov 24, 2022

melvin-bot bot added the Emergency label Nov 24, 2022

luacmartins removed the Emergency label Nov 24, 2022

OSBotify pushed a commit that referenced this pull request Nov 24, 2022

Merge pull request #13010 from margelo/@thomas/revert-fast-image

22b0b6f

Revert "Merge pull request #12648 from margelo/@thomas/fast-image-cac… (cherry picked from commit 01abc6f)

This was referenced Nov 24, 2022

🍒 Cherry pick PR #13010 to staging 🍒 #13016

Merged

Deploy Checklist: New Expensify 2022-11-23 #12976

Closed

luacmartins added a commit that referenced this pull request Nov 24, 2022

Merge pull request #13016 from Expensify/OSBotify-cherry-pick-staging…

0d1deaa

…-13010 🍒 Cherry pick PR #13010 to staging 🍒

OSBotify mentioned this pull request Nov 27, 2022

Deploy Checklist: New Expensify 2022-11-25 #13059

Closed

21 tasks

melvin-bot bot mentioned this pull request Nov 28, 2022

[$1000] [HOLD for payment 2022-12-05] Android - Attachments - PDF file is disappeared in the chat after sent it #13002

Closed

Beamanator mentioned this pull request Nov 30, 2022

[Image][Performance] Better caching for iOS images #10792

Closed

5 tasks

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Merge pull request #12648 from margelo/@thomas/fast-image-cac… #13010

Revert "Merge pull request #12648 from margelo/@thomas/fast-image-cac… #13010

thomas-coldwell commented Nov 24, 2022 •

edited by luacmartins

Loading

melvin-bot bot commented Nov 24, 2022

github-actions bot commented Nov 24, 2022

luacmartins commented Nov 24, 2022

thomas-coldwell commented Nov 24, 2022 •

edited

Loading

thomas-coldwell commented Nov 24, 2022 •

edited

Loading

luacmartins commented Nov 24, 2022 •

edited

Loading

melvin-bot bot commented Nov 24, 2022

luacmartins commented Nov 24, 2022

OSBotify commented Nov 24, 2022

luacmartins commented Dec 6, 2022

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

Revert "Merge pull request #12648 from margelo/@thomas/fast-image-cac… #13010

Revert "Merge pull request #12648 from margelo/@thomas/fast-image-cac… #13010

Conversation

thomas-coldwell commented Nov 24, 2022 • edited by luacmartins Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

PR Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Nov 24, 2022

github-actions bot commented Nov 24, 2022

luacmartins commented Nov 24, 2022

thomas-coldwell commented Nov 24, 2022 • edited Loading

thomas-coldwell commented Nov 24, 2022 • edited Loading

luacmartins commented Nov 24, 2022 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Nov 24, 2022

luacmartins commented Nov 24, 2022

OSBotify commented Nov 24, 2022

luacmartins commented Dec 6, 2022

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

thomas-coldwell commented Nov 24, 2022 •

edited by luacmartins

Loading

thomas-coldwell commented Nov 24, 2022 •

edited

Loading

thomas-coldwell commented Nov 24, 2022 •

edited

Loading

luacmartins commented Nov 24, 2022 •

edited

Loading