Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] [HOLD for payment 2022-12-05] Android - Attachments - PDF file is disappeared in the chat after sent it #13002

Closed
kbecciv opened this issue Nov 24, 2022 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Nov 24, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Launch App and login
  2. Navigate to any chat
  3. Sent PDF attachment

Expected Result:

Attachment should be sent and appeared in the chat

Actual Result:

The attachment was sent and not appeared in the chat.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.2.31.1

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5834950_PDF.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Nov 24, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Nov 24, 2022

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@0xmiros
Copy link
Contributor

0xmiros commented Nov 24, 2022

Found root cause.
Opened discussion in slack here

@mountiny
Copy link
Contributor

Thanks, from slack:

Root cause: DylanVann/react-native-fast-image#865
workaround: fix in native code (FastImageViewConverter.java)

@luacmartins
Copy link
Contributor

Looks like we will revert this PR. It can't be auto reverted though, so we'll work on a manual revert.

@mountiny
Copy link
Contributor

Thanks, the PR has been reverted and deployed to staging some time ago. I am going to close this issue, thanks for help

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Nov 28, 2022
@melvin-bot melvin-bot bot changed the title Android - Attachments - PDF file is disappeared in the chat after sent it [HOLD for payment 2022-12-05] Android - Attachments - PDF file is disappeared in the chat after sent it Nov 28, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 28, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.32-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-12-05. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@0xmiros
Copy link
Contributor

0xmiros commented Nov 29, 2022

@mountiny am I eligible for compensation? I found out the root cause and proposed a solution on slack as soon as this deploy blocker created.

@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment labels Nov 29, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 29, 2022

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Nov 29, 2022
@mountiny
Copy link
Contributor

Found root cause.
Opened discussion in slack here

I think it would make sense to have a same compensation as for reporting $250, the offending PR has been found quickly.

@mountiny
Copy link
Contributor

mountiny commented Nov 29, 2022

@conorpendergrast Could we please create Upwork job and Pay @0xmiroslav $250 bonus for helping identifying which PR caused this Deploy blocker?

Thanks for raising this @0xmiroslav

@mountiny mountiny reopened this Nov 29, 2022
@0xmiros
Copy link
Contributor

0xmiros commented Nov 29, 2022

Thanks @mountiny

@conorpendergrast conorpendergrast added the External Added to denote the issue can be worked on by a contributor label Nov 29, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 29, 2022

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot changed the title [HOLD for payment 2022-12-05] Android - Attachments - PDF file is disappeared in the chat after sent it [$1000] [HOLD for payment 2022-12-05] Android - Attachments - PDF file is disappeared in the chat after sent it Nov 29, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 29, 2022

Job added to Upwork: https://www.upwork.com/jobs/~01f9b2ebef492363fd

@melvin-bot
Copy link

melvin-bot bot commented Nov 29, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 29, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 29, 2022

Current assignee @mountiny is eligible for the External assigner, not assigning anyone new.

@conorpendergrast
Copy link
Contributor

@0xmiroslav Contract sent; please let me know when you've accepted and I'll pay it!

@conorpendergrast conorpendergrast removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 29, 2022
@conorpendergrast
Copy link
Contributor

Paid! Upwork isn't showing me the option to end the contract at the moment, so I'll keep this open for myself to check back on it

image

@conorpendergrast
Copy link
Contributor

Contract ended, all set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants