Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-11-25 #13059

Closed
21 tasks done
OSBotify opened this issue Nov 25, 2022 · 11 comments
Closed
21 tasks done

Deploy Checklist: New Expensify 2022-11-25 #13059

OSBotify opened this issue Nov 25, 2022 · 11 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Nov 25, 2022

Release Version: 1.2.32-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@mountiny
Copy link
Contributor

#12880 was reverted no need for QA

@mountiny
Copy link
Contributor

#12859 failed on iOS and fix is here, fix for Android will be resolved next morning. No need to revert or CP the fix, this only influences test workflows.

@luacmartins luacmartins self-assigned this Nov 25, 2022
@luacmartins luacmartins added the Daily KSv2 label Nov 25, 2022
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Nov 26, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.32-1 🚀

@melvin-bot melvin-bot bot added the Overdue label Nov 28, 2022
@mvtglobally
Copy link

mvtglobally commented Nov 28, 2022

Regression is completed

PR #12596 is failing #13062. It is not repro in PROD, but since its new feature with this PR, we did not label it as blocker, pls double check
PR #12761 is failing #13063. Repro in PROD
PR #12935 (comment) clarification required

@luacmartins
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Nov 28, 2022
@luacmartins
Copy link
Contributor

We still have one blocker left, looking at it now

@luacmartins
Copy link
Contributor

I see this "new" issue in Firebase. The offending PR has been on prod for almost a month and I'm putting up a fix for it here so won't block the deploy on it.

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.32-2 🚀

@luacmartins
Copy link
Contributor

luacmartins commented Nov 28, 2022

Tested #13093 and it seems to be working! Checking it off!
Screenshot 2022-11-28 at 1 09 38 PM

@luacmartins
Copy link
Contributor

:shipit:

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.32-2 has been deployed to staging 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants