Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#925: Changes to not run Github workflow actions for docs related PRs #928

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

suryavirkapur
Copy link
Contributor

Added simple code that ensures tests only run on go build/metadata files and go source code
#925

@@ -2,8 +2,18 @@ name: dice-test-suite
on:
push:
branches: [master]
paths:
- "**/*.go"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also consider main.go in current dir?

@@ -2,8 +2,18 @@ name: dice-test-suite
on:
push:
branches: [master]
paths:
- "**/*.go"
- "go.mod"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have it other way around like a blacklist of paths instead of whitelist?

Copy link
Contributor Author

@suryavirkapur suryavirkapur Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@lucifercr07 lucifercr07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing @suryavirkapur

@lucifercr07 lucifercr07 changed the title [Closes #925] Added paths to test-suite workflow #925: Changes to not run Github workflow actions for docs related PRs Oct 4, 2024
@lucifercr07 lucifercr07 merged commit 041124d into DiceDB:master Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants