-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#925: Changes to not run Github workflow actions for docs related PRs #928
Conversation
@@ -2,8 +2,18 @@ name: dice-test-suite | |||
on: | |||
push: | |||
branches: [master] | |||
paths: | |||
- "**/*.go" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will also consider main.go
in current dir?
@@ -2,8 +2,18 @@ name: dice-test-suite | |||
on: | |||
push: | |||
branches: [master] | |||
paths: | |||
- "**/*.go" | |||
- "go.mod" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have it other way around like a blacklist of paths instead of whitelist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lucifercr07, I have switched to having the paths blacklisted instead of the other way round.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for contributing @suryavirkapur
Added simple code that ensures tests only run on go build/metadata files and go source code
#925