Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally run unit tests and integration tests on CI #925

Closed
JyotinderSingh opened this issue Oct 2, 2024 · 3 comments
Closed

Conditionally run unit tests and integration tests on CI #925

JyotinderSingh opened this issue Oct 2, 2024 · 3 comments
Assignees
@sebzz2k2
Labels
difficulty-level -- easy good first issue Good for newcomers stack -- infra

Comments

@JyotinderSingh
Copy link
Collaborator

Currently unit tests and integration tests for the core server are executed even if no source code is changed. For instance, even if changes are made only to the docs/ directory the tests are still being run - this leads to compute wastage.

We need to modify the GitHub workflows to run integration and unit tests only when actual code files are modified.
@sebzz2k2
Copy link
Contributor

sebzz2k2 commented Oct 2, 2024

Hey @JyotinderSingh
Can i pick it up. I can give this a try
Thankyou

@JyotinderSingh
Copy link
Collaborator Author

Hey @JyotinderSingh
Can i pick it up. I can give this a try
Thankyou

Assigned.

@suryavirkapur suryavirkapur mentioned this issue Oct 2, 2024
Merged
lucifercr07 pushed a commit that referenced this issue Oct 4, 2024
@suryavirkapur
#925: Changes to not run Github workflow actions for docs related PRs (…
041124d 
…#928)
@lucifercr07
Copy link
Contributor

Closing, merged as part of #928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebzz2k2 sebzz2k2

Labels
difficulty-level -- easy good first issue Good for newcomers stack -- infra
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lucifercr07 @JyotinderSingh @sebzz2k2