Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#925: Changes to not run Github workflow actions for docs related PRs #928

Merged
merged 2 commits into from
Oct 4, 2024
Merged

#925: Changes to not run Github workflow actions for docs related PRs #928

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f58963b
added paths to test-suite workflow
suryavirkapur Oct 2, 2024
00ab954
switch whitelist (paths) to blacklist (paths-ignore)
suryavirkapur Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/full-test-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,18 @@ name: dice-test-suite
on:
push:
branches: [master]
paths:
- "**/*.go"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also consider main.go in current dir?

- "go.mod"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have it other way around like a blacklist of paths instead of whitelist?

Copy link
Contributor Author

@suryavirkapur suryavirkapur Oct 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lucifercr07, I have switched to having the paths blacklisted instead of the other way round.

Ref: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore

- "go.sum"
- "Makefile"
pull_request:
branches: [master]
paths:
- "**/*.go"
- "go.mod"
- "go.sum"
- "Makefile"

jobs:
build:
Expand All @@ -22,4 +32,4 @@ jobs:
- name: Run Unit tests
run: make unittest
- name: Run Integration tests
run: make test
run: make test