This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Bump upload/download artifact and configure dependabot to group them #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 16 16
=========================================
Hits 16 16 ☔ View full report in Codecov by Sentry. |
garryod
approved these changes
Jan 4, 2024
| @@ -36,9 +39,9 @@ runs: | |||
| shell: bash | |||
|
|
|||
| - name: Upload lockfiles | |||
| uses: actions/upload-artifact@v3 | |||
| uses: actions/upload-artifact@v4 | |||
There was a problem hiding this comment.
Might be nice to fully qualify the version here
| @@ -10,6 +10,9 @@ inputs: | |||
| python_version: | |||
| description: Python version to install | |||
| default: "3.x" | |||
| artifact_name: | |||
| description: A user friendly name to give the produced artifacts | |||
| default: "tests" | |||
There was a problem hiding this comment.
Might be better off without a default here 🤷
There was a problem hiding this comment.
Yh, I was only being lazy, I'll remove the default
2 tasks
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's required to bump both dependencies at the same time.
To test: