Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the release CI after bumping upload/download artifacts #276

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Jan 5, 2024

The changes made in DiamondLightSource/python3-pip-skeleton#161 (and cherry-picked here) weren't right for the release. This fixes that

Instructions to reviewer on how to test:

  1. Confirm that the below has been deployed to pypi

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4dd0b01) 89.69% compared to head (0616e20) 89.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          81       81           
  Lines        2968     2968           
=======================================
  Hits         2662     2662           
  Misses        306      306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dperl-dls dperl-dls merged commit 77cdfe9 into main Jan 8, 2024
24 checks passed
@dperl-dls dperl-dls deleted the fix_release_process branch January 8, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants