Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick changes from the skeleton #275

Merged
merged 24 commits into from
Jan 5, 2024
Merged

Cherry-pick changes from the skeleton #275

merged 24 commits into from
Jan 5, 2024

Conversation

DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Jan 4, 2024

Keeps us more inline with the pip skeleton, particularly on version bumps of CI things (like DiamondLightSource/python3-pip-skeleton#161)

Instructions to reviewer on how to test:

  1. Confirm CI is still happy

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards

evalott100 and others added 22 commits January 4, 2024 16:27
This will test the container before it is pushed to GHCR
Some tools remove trailing whitespace by default on save, so may as well
correct the originals.
Ensures every file ends with an empty blank line. Again some tools do
this automatically.
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 5.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v3...v5)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2 to 3.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@v2...v3)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the github-artifacts group with 1 update: [actions/download-artifact](https://github.com/actions/download-artifact).


Updates `actions/download-artifact` from 4.0.0 to 4.1.0
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v4.0.0...v4.1.0)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-artifacts
...

Signed-off-by: dependabot[bot] <[email protected]>
@DominicOram DominicOram marked this pull request as ready for review January 4, 2024 16:44
@DominicOram DominicOram changed the title Cherry-pick cahanges from the skeleton Cherry-pick changes from the skeleton Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (99b2010) 89.43% compared to head (56ce771) 89.43%.

Files Patch % Lines
src/dodal/__main__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   89.43%   89.43%           
=======================================
  Files          78       78           
  Lines        2829     2829           
=======================================
  Hits         2530     2530           
  Misses        299      299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for doing this

@DominicOram DominicOram merged commit c257085 into main Jan 5, 2024
15 of 16 checks passed
@DominicOram DominicOram deleted the update_deps branch January 5, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants