Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update GH unit test workflow DB #27

Merged
merged 14 commits into from
Sep 19, 2024
Merged

update GH unit test workflow DB #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0b021a2
update GH unit test workflow DB
ericbuckley Sep 18, 2024
4c37950
adding a postgres service healthcheck back
ericbuckley Sep 18, 2024
c5d73f3
removing health check
ericbuckley Sep 18, 2024
be67ee9
moving the healthcheck to the service
ericbuckley Sep 18, 2024
f541709
changing hostname to postgres
ericbuckley Sep 18, 2024
4a3843b
reverting back to localhost
ericbuckley Sep 18, 2024
9d2a2ed
being explicit with the postgres username and dbname
ericbuckley Sep 18, 2024
44ab680
trying another name for the postgres db
ericbuckley Sep 18, 2024
553bd81
adding debugging step
ericbuckley Sep 18, 2024
5141066
moving debug to the end
ericbuckley Sep 18, 2024
99b1efc
have to debug before the unit tests fail
ericbuckley Sep 18, 2024
e9714b5
pinning pyway to 0.3.29
ericbuckley Sep 18, 2024
4053ed1
revert to old workflow now that we know the issue is releated to pywa…
ericbuckley Sep 18, 2024
b7a0f55
removing extra whitespace
ericbuckley Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions .github/workflows/check_unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ jobs:
- 5432:5432
env:
POSTGRES_PASSWORD: pw
POSTGRES_DB: testdb

steps:
- name: Checkout code
Expand All @@ -40,11 +39,6 @@ jobs:

- name: Run unit tests
env:
MPI_DB_TYPE: postgres
MPI_DBNAME: testdb
MPI_HOST: localhost
MPI_PORT: 5432
MPI_USER: postgres
MPI_PASSWORD: pw
DB_URI: "postgresql+psycopg2://postgres:pw@localhost:5432/postgres"
derekadombek marked this conversation as resolved.
Show resolved Hide resolved
run: |
pytest --cov=recordlinker --cov-report=xml tests/unit
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies = [
"fhirpathpy",
"rapidfuzz",
# TODO: replace pyway with alembic for managing database migrations
"pyway"
"pyway==0.3.29"
]

[project.optional-dependencies]
Expand Down
Loading