Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update GH unit test workflow DB #27

Merged
merged 14 commits into from
Sep 19, 2024

Conversation

ericbuckley
Copy link
Collaborator

@ericbuckley ericbuckley commented Sep 18, 2024

Description

The latest version of pyway, 0.3.30, is not able to read the existing migrations directory. Since these migrations are deprecated in favor of alembic, the easiest path forward is to pin pyway to version 0.3.29 until its removed from the project.

Within #19 we simplified the settings to use the new DB_URI env variable to define connection settings. We forgot to also update update postgres database setup in the GH testing workflow to follow this pattern.

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.
  • I have notified teammates in the review thread to build awareness.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

Within #19 we simplified the settings to use the new DB_URI env
variable to define connection settings.  We forgot to also update
update postgres database setup in the GH testing workflow to follow
this pattern.
@ericbuckley ericbuckley added the bug Something isn't working label Sep 18, 2024
@ericbuckley ericbuckley self-assigned this Sep 18, 2024
@ericbuckley ericbuckley marked this pull request as ready for review September 18, 2024 15:35
@ericbuckley ericbuckley merged commit f9f3bb3 into main Sep 19, 2024
4 checks passed
@ericbuckley ericbuckley deleted the ericbuckley/fix-gh-postgres-unit-test-setup branch September 19, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants