remove hardcoded test settings #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericbuckley
requested review from
alhayward,
cbrinson-rise8 and
derekadombek
as code owners
derekadombek
approved these changes
Sep 17, 2024
alhayward
approved these changes
Sep 17, 2024
ericbuckley
added a commit
that referenced
this pull request
Sep 18, 2024
Within #19 we simplified the settings to use the new DB_URI env variable to define connection settings. We forgot to also update update postgres database setup in the GH testing workflow to follow this pattern.
10 tasks
ericbuckley
added a commit
that referenced
this pull request
Sep 19, 2024
## Description The latest version of pyway, 0.3.30, is not able to read the existing migrations directory. Since these migrations are deprecated in favor of alembic, the easiest path forward is to pin pyway to version 0.3.29 until its removed from the project. Within #19 we simplified the settings to use the new DB_URI env variable to define connection settings. We forgot to also update postgres database setup in the GH testing workflow to follow this pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplifying database settings via one environment variable and updating test cases to use that rather than having everything hard-coded.
Additional Notes
pyway is the one exception to where the database parameters require individual values rather than a database URI. This is however deprecated functionality, as we'll be moving away from this and in favor of alembic so we can more easily support different database servers (also pyway doesn't support Microsoft SQL Server, which is what NBS uses).
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: