Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Hosp Only Model from cdcgov/wastewater-informed-covid-forecasting #313

Closed
wants to merge 51 commits into from

Conversation

damonbayer
Copy link
Collaborator

@damonbayer damonbayer commented Jul 24, 2024

This PR recreates "Model 2" from the wastewater-informed-covid-forecasting project. The model is described here. Stan code for the model is here.

The tutorial demonstrates how to use the model with stan_data generated in the wastewater-informed-covid-forecasting project. As such, recreating any analysis from that project should be relatively straightforward.

Closes #174.
Closes #13.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 21.73913% with 54 lines in your changes missing coverage. Please review.

Project coverage is 88.12%. Comparing base (bf09a37) to head (22bc13e).

Files Patch % Lines
model/src/pyrenew/model/hosp_only_ww_model.py 19.40% 54 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
- Coverage   93.17%   88.12%   -5.06%     
==========================================
  Files          39       40       +1     
  Lines         909      977      +68     
==========================================
+ Hits          847      861      +14     
- Misses         62      116      +54     
Flag Coverage Δ
unittests 88.12% <21.73%> (-5.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damonbayer damonbayer requested a review from sbidari August 2, 2024 22:17
@damonbayer
Copy link
Collaborator Author

I think this is ready to be handed off until I am able to work on it again. Things are a bit rough, but I am hoping what I have provided is sufficient for @sbidari to begin validating the model (which I have not done at all). I would accept PR's against this branch, should someone want to make changes here. It is certainly not ready for merging to main.

Copy link
Collaborator Author

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes

  • If we want to include the stan_data files. They should go in the same place as the rest of the data and have convenience functions for loading them.
  • RtWeeklyDiffProcess should probably not be used (@dylanhmorris can say more)
  • There is some strange behavior where simulating from the prior predictive causes the posterior inference to fail.
  • I copied variable names from the wastewater-informed-covid-forecasting model, which could probably be improved.

@dylanhmorris dylanhmorris mentioned this pull request Aug 6, 2024
@damonbayer damonbayer linked an issue Aug 19, 2024 that may be closed by this pull request
5 tasks
@damonbayer
Copy link
Collaborator Author

Migrated to https://github.com/CDCgov/pyrenew-covid-wastewater/. See CDCgov/pyrenew-covid-wastewater#3 & CDCgov/pyrenew-covid-wastewater#4

@damonbayer damonbayer closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Hosp Only Model from cdcgov/wastewater-informed-covid-forecasting Time-varying IHR
2 participants