-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor dispatch #387
refactor dispatch #387
Conversation
71da3d0
to
810da3a
Compare
Instead of overloading request.headers for implicit content negotiation and autoindexing, store the needed info in a dispatch_result.extra dict, passing dispatch_result around as needed.
@pjz I have more to do here to fully modularize the dispatcher (removing references to Aspen request, response, and website objects), but the commits so far should leave the code in a stable state if you want to merge sooner rather than later. |
Blech. Broke the tests. :-/ Outta steam for now, will pick up with this again later ... |
I like the way this is trending. I've pondered trying to make the dispatcher usable by Flask before (since that's a very pure-WSGI stack); that might also be a worthy goal. |
7adcdf0
to
78c72c5
Compare
Okay! Ready for review, @pjz. :-) I decided not to take out the dependency on |
Closing in favor of #388. |
Refactor the dispatcher so that it doesn't depend on Aspen's request, response and website objects. I want to be able to use the dispatcher inside of Django.
Builds on #385/#386.