Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove request.fs #388

Closed
wants to merge 17 commits into from
Closed

remove request.fs #388

wants to merge 17 commits into from

Conversation

chadwhitacre
Copy link
Contributor

Builds on #387. We don't need request.fs anymore, now that we expose the same thing as dispatch_result.match.

@chadwhitacre
Format dispatcher for 100 chars
9738437
@chadwhitacre
Prune unused imports
55f903c
@chadwhitacre
Failing tests for dispatch returning a result
810da3a
@chadwhitacre
Return a result from dispatcher.dispatch
bfa061f
@chadwhitacre
Stop abusing request.headers
e0e4f6c 
Instead of overloading request.headers for implicit content negotiation
and autoindexing, store the needed info in a dispatch_result.extra dict,
passing dispatch_result around as needed.
@chadwhitacre
Remove dependence on request.uri in dispatcher
1555bdb
@chadwhitacre
Move setting of request.fs out of dispatcher
ba08b26
@chadwhitacre
Stop passing request to dispatch entirely
45cf394
@chadwhitacre
Get test suite passing again
6e0d7f3
@chadwhitacre
Remove dependency on website.media_type_default
52bac47
@chadwhitacre
Remove dependency on website.indices
d2c007c
@chadwhitacre
Remove dependency on website.www_root
5e6ac6d
@chadwhitacre
Remove website.list_directories & .ours_or_theirs
78c72c5
@chadwhitacre
Remove website entirely from dispatcher
bebf158
@chadwhitacre
Remove request.fs
9c3d625 
Now that we expose dispatch_result to simplates and in the algorithm
state, we no longer need to store the filesystem path at request.fs.
Yay for modularity!
@chadwhitacre
Disentangle the request object from resources.get
cbe490d
@chadwhitacre
Go back to namedtuple for DispatchResult
0a06fd0 
https://botbot.me/freenode/aspen/2014-10-03/?msg=22822660&page=1
@chadwhitacre chadwhitacre mentioned this pull request Oct 3, 2014
Closed
@chadwhitacre
Copy link
Contributor Author

Closing in favor of #387.

@chadwhitacre chadwhitacre deleted the remove-request-fs branch October 3, 2014 18:46
@chadwhitacre chadwhitacre mentioned this pull request Oct 3, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chadwhitacre