remove request.website #386
Conversation
I'm trying to get rid of request.website, so that instead we just pass
in the website object where ever we need it. In simplate contexts,
website is available as a global. It's unpythonic ("one right way") and
overcomplicated to have it also available at request.website.
We have website already in simplate contexts.
Pass in website object instead.
|
So... I really hate reformatting patches because they obscure the actual trail of who made what actual code changes. |
|
@pjz So what's the solution? You want to include reformatting changes in with other changes? I've usually considered that an antipattern as well since it makes it harder to see the "real" changes in a commit. |
|
If you want to commit the 100-char reformat, I'm happy to rebase #387 on master once that's landed. |
|
Yeah, if you need to reformat, do so iff you're already changing that line. That way, all changes are real, substantive changes, so if later there's a bug in that line, 'git blame' will have the correct answer to 'who wrote that line of code', which it won't if you reformat everything. |
|
@pjz Okay, that makes it more important to format code correctly in the first place. ;-) |
|
Yeah. Honestly, this is a problem that should be solved via a git hook that rejects incorrectly-formatted commits (where 'incorrectly-formatted' is defined as 'not matching the output of that source code run through the prettyprinter with agreed-upon settings') so that everything is both well formatted and correctly attributed. Golang does this, I think. I haven't seen corresponding python examples.. |
|
Closing in favor of #387. |
chadwhitacre
changed the title
|
Actually, leaving open but retitling. |
|
Can you also back out the dispatcher reformatting? |
|
nevermind, I'll just make you fix it if it breaks :) |
|
:-) |
Builds on #385.