Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

40 finish first version of gym interface #50

Merged
merged 44 commits into from
Jan 21, 2024
Merged

Conversation

Armandpl
Copy link
Owner

@Armandpl Armandpl commented Jan 17, 2024

Opening PR as draft because there is at least one question that needs answering before finishing this.

  • do we want to implement a command to reset only the motor encoder? -> no
    • here is how we handle env reset now: we wait for the pendulum to stay in a cone for a set amount of time after which we consider it is at rest and we reset BOTH the motor encoder and the pendulum encoder. This is making me think there is a small chance the pendulum might still be moving at that time or maybe it stopped slightly off from 0 because of frictions. This means when resetting the pendulum the zero is going to move a little bit.
      • is this an issue?
      • even if we add the option not to reset the pendulum, the zero is set when we power on the robot so we have the same issue? if the pendulum is slightly off the zero is going to be slightly off? -> so no need to implement this

@Armandpl Armandpl linked an issue Jan 17, 2024 that may be closed by this pull request
14 tasks
@Armandpl Armandpl changed the title 40 finish gym interface 40 finish first version of gym interface Jan 17, 2024
@Armandpl Armandpl marked this pull request as ready for review January 18, 2024 18:33
@Armandpl Armandpl requested a review from pierfabre January 18, 2024 18:33
scripts/train.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@pierfabre pierfabre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments, apart from that lgtm

@pierfabre pierfabre merged commit f14e8ef into master Jan 21, 2024
2 checks passed
@pierfabre pierfabre deleted the 40-finish-gym-interface branch January 21, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

finish gym interface
2 participants