Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish gym interface #40

Closed
11 of 14 tasks
Armandpl opened this issue Jan 7, 2024 · 0 comments · Fixed by #50
Closed
11 of 14 tasks

finish gym interface #40

Armandpl opened this issue Jan 7, 2024 · 0 comments · Fixed by #50

Comments

@Armandpl
Copy link
Owner

Armandpl commented Jan 7, 2024

  • make sure sim timing and robot timing are the same
    • e.g if we call step on the real robot we get back the angle readings at t
    • make it so its the same in sim
  • handle reset
    • wait for it to stop moving
      • handle the case were it stopped off from 0 which probably means the encoder slipped -> eh just reset every time
    • reset motor position to zero
  • make sim follow the same interface as Robot in robot.py THEN wrap in gym env
  • vectorize training
  • clean up the way we instantiate wrappers
  • check how to seed env now that we're supposed to pass seed to reset? should we pass the seed to sb3? why are we seeding on reset even?
  • make it so we use DummyVecEnv and not SubprocVecEnv when training on the real robot
  • fix video saving. currently it fails and only records the first frame.
    • only on the remote machine?
  • fix model names when saving loading. use the same name for every algo
  • finish choosing how to setup state_space #56
  • scale viewport width scale based on the max/min theta angle. e.g -width/2 = -min_theta
    • use the safety limits? or the obs limits? or just -pi/pi and wrap? I think that makes more sense
  • display degrees on the cartpole track
  • add pytest to CI
    • can we mock the robot to test the real env?
  • quickfix for match case not available in python3.9 #57 to pass tests and lint
@Armandpl Armandpl mentioned this issue Jan 7, 2024
31 tasks
@pierfabre pierfabre mentioned this issue Jan 7, 2024
11 tasks
@Armandpl Armandpl linked a pull request Jan 17, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant