Create and use AP_PERIPH_RANGEFINDER_ENABLED #29203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
requested changes
Jan 31, 2025
| @@ -91,7 +91,7 @@ define GPS_MAX_RECEIVERS 1 | |||
| define GPS_MAX_INSTANCES 1 | |||
|
|
|||
| # rangefinder | |||
| define HAL_PERIPH_ENABLE_RANGEFINDER 2 | |||
| define AP_PERIPH_RANGEFINDER_ENABLED 1 2 | |||
There was a problem hiding this comment.
This doesn't look right. And does "2" do something?!
There was a problem hiding this comment.
Fixed that. I did check it though, but there are so many of them that this one slipped through my sight again. I'll be more careful next time.
shiv-tyagi
force-pushed
the
ap-periph-rf-enabled
branch
from
1306136 to
3fe0a99
Compare
peterbarker
approved these changes
Feb 1, 2025
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #29186