-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plane:adjust CTUN.Pitch to remove PITCH_TRIM #29152
Conversation
@Hwurzburg perhaps you'd like to take a look at #29067 I think it gets the same result as this one (have comparable pitch quantities) by following a complementary path. |
I am against adding Pitch trim in desired to make it match pitch ..then when flying level the desired pitch no longer is zero ...zero should indicate the vehicle is level on its artificial horizon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, should we add a note to the log message documentation here?:
Lines 315 to 316 in 2cd3970
// @Field: NavPitch: desired pitch | |
// @Field: Pitch: achieved pitch |
added...a bit long but prevents confusion I think |
We have ATT.Pitch, CTUN.Pitch, XKF1.Pitch all reporting the same pitch with PITCH_TRIM added, so there are no two log lines that one can graph showing desired/nav pitch vs reported pitch to check if pitch tuning is closely matching to indicate good tune....
removing PITCH_TRIM_DEG bias from one would allow an easy graphical evaluation of Pitch tune....doing it in ATT is problematic since its in AHRS and spans vehicle types....modifying CTUN.Pitch is easy and only affects FW Plane...the other two pitch logs are unaffected.
This also aligns with HUD artificial horizon visual indication