Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane:adjust CTUN.Pitch to remove PITCH_TRIM #29152

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Hwurzburg
Copy link
Collaborator

@Hwurzburg Hwurzburg commented Jan 27, 2025

We have ATT.Pitch, CTUN.Pitch, XKF1.Pitch all reporting the same pitch with PITCH_TRIM added, so there are no two log lines that one can graph showing desired/nav pitch vs reported pitch to check if pitch tuning is closely matching to indicate good tune....

removing PITCH_TRIM_DEG bias from one would allow an easy graphical evaluation of Pitch tune....doing it in ATT is problematic since its in AHRS and spans vehicle types....modifying CTUN.Pitch is easy and only affects FW Plane...the other two pitch logs are unaffected.

This also aligns with HUD artificial horizon visual indication

@Georacer
Copy link
Contributor

@Hwurzburg perhaps you'd like to take a look at #29067

I think it gets the same result as this one (have comparable pitch quantities) by following a complementary path.

@Hwurzburg
Copy link
Collaborator Author

I am against adding Pitch trim in desired to make it match pitch ..then when flying level the desired pitch no longer is zero ...zero should indicate the vehicle is level on its artificial horizon

ArduPlane/Log.cpp Outdated Show resolved Hide resolved
tridge
tridge previously requested changes Jan 29, 2025
ArduPlane/Log.cpp Outdated Show resolved Hide resolved
@Hwurzburg
Copy link
Collaborator Author

Hwurzburg commented Jan 30, 2025

okay, I think this is good now....here is a SITL log of a quadplane in all different flight modes with this logging now:
graph

@Hwurzburg Hwurzburg requested review from tridge and IamPete1 January 30, 2025 02:03
ArduPlane/Log.cpp Outdated Show resolved Hide resolved
Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, should we add a note to the log message documentation here?:

ardupilot/ArduPlane/Log.cpp

Lines 315 to 316 in 2cd3970

// @Field: NavPitch: desired pitch
// @Field: Pitch: achieved pitch

@Hwurzburg
Copy link
Collaborator Author

added...a bit long but prevents confusion I think

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Feb 2, 2025
@tridge tridge dismissed their stale review February 4, 2025 00:29

fixed, thanks!

@tridge tridge merged commit a2ca9be into ArduPilot:master Feb 4, 2025
70 checks passed
@Hwurzburg Hwurzburg deleted the pitch-trim branch February 4, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WikiNeeded needs wiki update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants