Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_Mount: zoom for Viewpro IR sensor #29140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AP_Mount: zoom for Viewpro IR sensor #29140

wants to merge 1 commit into from
+42 −10

Conversation

eppravitra
Copy link
Contributor

Add zoom function for ViewPro IR sensor. Also read IR zoom value from Viewpro

@rmackay9
Copy link
Contributor

Hi @eppravitra,

Thanks for this, it looks pretty good to me with the exception of a few white space issues.

I guess you've tested this on real hardware? Normally we like to hear what testing has been done because it gives us more confidence that it's ready to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmackay9 rmackay9 rmackay9 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eppravitra @rmackay9