Update clang pragma that is causing trouble #28490
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,10 +1,5 @@ | |||
| #include "Copter.h" | |||
|
|
|||
| #pragma GCC diagnostic push | |||
| #if defined(__clang__) | |||
There was a problem hiding this comment.
This warning was added in Clang v14. Better to update the check rather than remove it, e.g.:
#if defined(__clang_major__) && __clang_major__ >= 14
There was a problem hiding this comment.
Okay, thanks, I will update the check then instead of removing it.
…t introduces the warning AP_Arming: Update clang pragma to check for the version of clang that introduces the warning
katzfey
force-pushed
the
pr-fix-qurt-clang-compiler-warning
branch
from
75813b1
to
eddf8c1
Compare
katzfey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update a clang pragma to check for the proper version of clang that introduces the warning.