Tools: autotest: Test guided altitude commands in Plane #28487
+54
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add a test for
master
to preserve existing behavior of planes guided SET_POSITION_TARGET_GLOBAL_INT support where you set the bitmask to only change the vehicle altitude.This is to be sure that the small cleanup in #28479 does not cause regressions.
As far as I can tell, the guided change altitude plane API in MAVLink is not tested in CI.
Details
The existing
SetpointGlobalPos
class is used on copter and rover tests, but not in Plane. Although it has some conditions for plane in the code, those are likely leftovers from something else. None of the existing tests will pass on plane because they aren't implemented.I'm hung up right now on why
MAV_FRAMES_TO_TEST
list includesMAV_FRAME_GLOBAL
, but theto_alt_frame
function does not include a converter.FS_GCS_ENABLE
cannot be set to 0AutoTestPlane.fly_home_land_and_disarm
invehicle_test_suite.TestSuite
, which couples the classesLogs right now show that the vehicle is trying to climb to 750m, starting at CMAC, and I suspect it's because MAV_FRAME_GLOBAL is not having the home altitude taken off.
Logs
ArduPlane-SetpointGlobalPos.txt