Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: autotest: Test guided altitude commands in Plane #28487

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Oct 28, 2024

Purpose

Add a test for master to preserve existing behavior of planes guided SET_POSITION_TARGET_GLOBAL_INT support where you set the bitmask to only change the vehicle altitude.

This is to be sure that the small cleanup in #28479 does not cause regressions.
As far as I can tell, the guided change altitude plane API in MAVLink is not tested in CI.

Details

The existing SetpointGlobalPos class is used on copter and rover tests, but not in Plane. Although it has some conditions for plane in the code, those are likely leftovers from something else. None of the existing tests will pass on plane because they aren't implemented.

I'm hung up right now on why

  • The MAV_FRAMES_TO_TEST list includes MAV_FRAME_GLOBAL, but the to_alt_frame function does not include a converter.
  • If the vehicle type is plane, FS_GCS_ENABLE cannot be set to 0
  • Whether it's ok to call AutoTestPlane.fly_home_land_and_disarm in vehicle_test_suite.TestSuite, which couples the classes

Logs right now show that the vehicle is trying to climb to 750m, starting at CMAC, and I suspect it's because MAV_FRAME_GLOBAL is not having the home altitude taken off.

Uploading image.png…

Logs

ArduPlane-SetpointGlobalPos.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants