Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_BattMonitor: Add the battery critical action delay time #28443

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muramura
Copy link
Contributor

@muramura muramura commented Oct 21, 2024

The battery failsafe includes both a warning and a critical stage.

Each stage has its own action settings. There is a duration during which the voltage is continuously monitored before the action is taken. For example, due to motor load, the battery voltage can drop to the critical level.

Currently, the duration for both the warning and the critical voltage levels is the same. If the voltage drops below the critical level, the drone may lose thrust.

By setting different durations for the warning and critical stages, appropriate actions can be taken.

Screenshot from 2024-10-21 23-36-34

BATT_CRT_TIMER set 0
Screenshot from 2024-10-22 07-20-06

BAT_CRT_TIMER set 1000
Screenshot from 2024-10-22 07-26-42

@muramura muramura force-pushed the AP_Add_the_battery_critical_action_delay_time branch from a14d010 to f2164c9 Compare October 21, 2024 21:28
@muramura muramura force-pushed the AP_Add_the_battery_critical_action_delay_time branch from f2164c9 to 462d2bb Compare October 21, 2024 22:29
@IamPete1
Copy link
Member

I don't understand why you would want a different time for each in the real world?

@muramura
Copy link
Contributor Author

@IamPete1 san.
There are times when the voltage drops suddenly—for example, due to poor contact in the battery connector. In such cases, the FC (Flight Controller) may not be able to execute emergency actions within the same time frame as warnings.

I believe it's acceptable for the durations of warnings and emergencies to be separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants