Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_DDS: Service to check if vehicle is armable #28401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tizianofiorenzani
Copy link
Contributor

@tizianofiorenzani tizianofiorenzani commented Oct 14, 2024

Issue

Closes #28286

What Changed

Response:

  • success (true if armable)
  • message: a string message (Vehicle is armable or Vehicle is NOT armable).

Test

Run the SITL and then use the DDS test to verify that vehicle is armable:

colcon build --packages-up-to ardupilot_dds_tests 
source install/setup.bash
ros2 run ardupilot_dds_tests pre_arm_check

Or call the service manually:

ros2 service list

/ap/arm_motors
/ap/mode_switch
/ap/prearm_check

ros2 service call /ap/prearm_check std_srvs/srv/Trigger 
requester: making request: std_srvs.srv.Trigger_Request()

response:
std_srvs.srv.Trigger_Response(success=True, message='Vehicle is Armable')

@tizianofiorenzani tizianofiorenzani marked this pull request as draft October 14, 2024 16:54
@tizianofiorenzani
Copy link
Contributor Author

@Ryanf55 I have trouble getting the services working with the pytest fixture. I have added a runtime test that can be run with

ros2 run ardupilot_dds_tests pre_arm_check

@tizianofiorenzani tizianofiorenzani force-pushed the wips/dds-is-armable branch 2 times, most recently from 91ad75c to b69f09c Compare October 15, 2024 15:54
@tizianofiorenzani tizianofiorenzani marked this pull request as ready for review October 15, 2024 15:55
@tizianofiorenzani tizianofiorenzani force-pushed the wips/dds-is-armable branch 3 times, most recently from 4045955 to 1f865e4 Compare October 18, 2024 18:42
@tizianofiorenzani tizianofiorenzani force-pushed the wips/dds-is-armable branch 2 times, most recently from d3a5b86 to b7d445a Compare October 29, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

AP_DDS - Prearm - Is Vehicle Armable DDS Interface
2 participants