AP_HAL_ESP32: RCOutput ported to new mcpwm driver #28370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arg7
force-pushed
the
hal_esp32_mcpwm_wip
branch
from
4164194
to
fe8d429
Compare
|
What's wrong with the old code that it needed all these changes? |
|
Old driver was deprecated and will be removed in next idf 6.x release. I don't like new driver, it hides actual hardware implementation too much, to my taste. And much more verbose. The only positive is that it is possible to use one timer for group of six rc out pins, so they work synchronized and may consume less power. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported RCOutput code to new MCPWM driver
Best regards,
A. Romanov