Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_DroneCAN: DNAServer: optimize allocation strategy #28099

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

tpwrules
Copy link
Contributor

@tpwrules tpwrules commented Sep 14, 2024

Please see code for details. There are sure to be a lot of variables but this change demonstrably makes the allocation message count (and therefore real allocation time, though I did not measure this precisely) lower and more consistent.

Number of allocation messages with 3x MatekL431-Periph nodes and Cube Orange (6 trials):

before: 44, 36, 35, 92, 107, 41

after: 28, 28, 28, 28, 26, 28

Number of allocation messages with 3 nodes (6 trials):

before: 44, 36, 35, 92, 107, 41

after: 28, 28, 28, 28, 26, 28
Copy link
Member

@bugobliterator bugobliterator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tridge tridge merged commit 12a1063 into ArduPilot:master Sep 17, 2024
95 checks passed
@tpwrules tpwrules deleted the pr/dna-optimize-alloc branch September 17, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants