Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_OSD: don't go via RCMap singleton to get RPTY RC channels #28095

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

peterbarker
Copy link
Contributor

Tested in SITL using --osd

Extracted from #28089

@peterbarker
Copy link
Contributor Author

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *                                                                     
Durandal                            *      *           -8      -8                -8     -8     *
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           0       0                 0      0      *
MatekF405                           *      *           0       0                 0      0      *
Pixhawk1-1M-bdshot                  *                  *       *                 *      *      *
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           *      *           0       0                 0      0      *
skyviper-v2450                                         *                                       

if (chan == nullptr) {
return RC_Channel::AuxSwitchPos::LOW;
}
const auto chan = &chanref;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd prefer const auto *chan = &chanref;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@peterbarker peterbarker merged commit 8b50f3b into ArduPilot:master Sep 17, 2024
94 of 95 checks passed
@peterbarker peterbarker deleted the pr/rcmap-osd-change branch September 17, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants