Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITL: param whitelist removal #28077

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

YuxinPan
Copy link
Contributor

Followed instructions in #22903 to remove params from whitelist and add to documentation. @YuxinPan

In this PR, all params with an exact name match in SITL.cpp are removed from the whitelist:

 - find a parameter name in the the get_sim_parameter_documentation_get_whitelist method in Tools/autotest/vehicle_test_suite.py which looks like you could document
 - remove it from the whitelist
 - Open libraries/SITL/SITL.cpp in editor
 - search for your parameter name, but omit the "SIM" part.

@peterbarker

@YuxinPan YuxinPan marked this pull request as ready for review September 11, 2024 08:07
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterbarker
Copy link
Contributor

I've split the commits to conform to our standards.

We have a document on cleaning commit up here: https://ardupilot.org/dev/docs/git-interactive-rebase.html

This is to match our style requirements, linked from that page.

@tridge
Copy link
Contributor

tridge commented Sep 11, 2024

@YuxinPan thank you!

@tridge tridge merged commit adc147a into ArduPilot:master Sep 11, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants