Add support for Connector loopback testing for Ethernet #28073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
previously requested changes
Sep 11, 2024
| SocketAPM::inet_addr_to_str(get_ip_active(), ipstr, sizeof(ipstr)); | ||
| if (!listen_sock->bind(ipstr, 9)) { | ||
| GCS_SEND_TEXT(MAV_SEVERITY_ERROR, "connector_loopback: failed to bind"); | ||
| return; |
There was a problem hiding this comment.
Leaking listen_sock here. Similarly elsewhere; use a fail: pattern?
| } | ||
| GCS_SEND_TEXT(MAV_SEVERITY_INFO, "connector_loopback: listening"); | ||
| // create discard client | ||
| auto *client = new SocketAPM(false); |
| uint32_t last_report_ms = AP_HAL::millis(); | ||
| uint32_t total_rx = 0; | ||
| while (true) { | ||
| if ((param.tests & TEST_CONNECTOR_LOOPBACK) == 0) { |
There was a problem hiding this comment.
A test_enabled(Test::CONNECTOR_LOOPBACK)` thing would be a nice cleanup
| hal.scheduler->delay(1); | ||
| continue; | ||
| } | ||
| client->send(buf, 1024); |
There was a problem hiding this comment.
I'm pretty sure Valgrind would not like this; maybe just zero it on the stack.
I'd actually suggest something non-zero in case there's some ridiculous optimisation somewhere. Perhaps:
for (uint8_t i=0; i<ARRAY_SIZE(buf); i++) {
buf[i] = i;
}
There was a problem hiding this comment.
changed to using memset to set all the values to 0xab
tridge
reviewed
Sep 11, 2024
bugobliterator
force-pushed
the
pr-eth-loopback-test
branch
from
882b33f
to
d473aae
Compare
bugobliterator
force-pushed
the
pr-eth-loopback-test
branch
from
c7c6e4d
to
cb6dec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested working on CubePilot PPPGW