Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane: added Q_APPROACH_DIST #28072

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Sep 11, 2024

this sets a minimum distance to use the fixed wing approach logic. It is an alternative to just disabling the approach with Q_OPTIONS which some users do to avoid some short distance problems. This allows the approach to still be used for longer distances in QRTL but have it disabled for shorter distances
The approach code is really needed for longer distances to allow the full fixed wing terrain following logic to be used

@tridge tridge added the WikiNeeded needs wiki update label Sep 11, 2024
ArduPlane/quadplane.cpp Outdated Show resolved Hide resolved
@timtuxworth
Copy link
Contributor

This seems like a good idea, but the interaction with the Q_OPTIONS is very confusing. If I understand this correctly, DISABLE_APPROACH actually means disable fixed wing approach, is that right? and if so the new behavior seems to be:

16: Disable Approach - always disable use of fixed wing approach and airbrake stages in VTOL landing, overriding Q_APPROACH_DIST if set

Do I have that right?

// @Range: 0.0 1000
// @Increment: 1
// @User: Standard
AP_GROUPINFO("APPROACH_DIST", 39, QuadPlane, approach_distance, 0),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it's a bit of a mouthful, we already have Q_FW_LND_APR_RAD - so for consistency, it might make sense to call this Q_FW_LND_APR_DST.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q_FW_LND_APR_RAD is related to the circle before transition into the wind stuff. Its not the same thing.

this sets a minimum distance to use the fixed wing approach logic. It
is an alternative to just disabling the approach with Q_OPTIONS which
some users do to avoid some short distance problems. This allows the
approach to still be used for longer distances in QRTL but have it
disabled for shorter distances
@tridge tridge merged commit f3b4f8f into ArduPilot:master Sep 12, 2024
65 checks passed
@Hwurzburg
Copy link
Collaborator

@tridge does this impact the code that prevents switch to fw approach if in vtol closer than 1.5x maxrad? I assume not..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants