Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GCS_SEND_TEXT in place of gcs().send_text #27776

Merged
merged 24 commits into from
Aug 7, 2024
Merged

Use GCS_SEND_TEXT in place of gcs().send_text #27776

merged 24 commits into from
Aug 7, 2024

Conversation

peterbarker
Copy link
Contributor

Replaces #25262

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  -120                                                                  
Durandal                            *      *           *       *                 *      *      *
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           *       *                 *      *      *
MatekF405                           *      *           *       *                 *      *      *
Pixhawk1-1M-bdshot                  *                  *       *                 *      *      *
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           *      *           *       *                 *      *      *
skyviper-v2450                                         *

peterbarker and others added 24 commits August 7, 2024 13:17
@peterbarker @muramura
AC_AutoTune: use GCS_SEND_TEXT rather than gcs().send_text
9960942 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AC_Fence: use GCS_SEND_TEXT rather than gcs().send_text
0aeaa0e 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_AdvancedFailsafe: use GCS_SEND_TEXT rather than gcs().send_text
7b0a10a 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_Baro: use GCS_SEND_TEXT rather than gcs().send_text
1658261 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_BattMonitor: use GCS_SEND_TEXT rather than gcs().send_text
a626d6c 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_Beacon: use GCS_SEND_TEXT rather than gcs().send_text
61e77c4 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_BoardConfig: use GCS_SEND_TEXT rather than gcs().send_text
827cff7 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_Camera: use GCS_SEND_TEXT rather than gcs().send_text
5574118 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_Compass: use GCS_SEND_TEXT rather than gcs().send_text
43b545b 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_Follow: use GCS_SEND_TEXT rather than gcs().send_text
25add46 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_Generator: use GCS_SEND_TEXT rather than gcs().send_text
0cf814f 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_HAL_ChibiOS: use GCS_SEND_TEXT rather than gcs().send_text
79b7a9d 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_HAL_ESP32: use GCS_SEND_TEXT rather than gcs().send_text
3b9cf8f 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_LandingGear: use GCS_SEND_TEXT rather than gcs().send_text
d4497d3 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_Logger: use GCS_SEND_TEXT rather than gcs().send_text
64c5d9b 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_Mount: use GCS_SEND_TEXT rather than gcs().send_text
a07fe9a 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_Proximity: use GCS_SEND_TEXT rather than gcs().send_text
0c58470 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_Radio: use GCS_SEND_TEXT rather than gcs().send_text
6c3a27c 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_RangeFinder: use GCS_SEND_TEXT rather than gcs().send_text
fa17422 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_Soaring: use GCS_SEND_TEXT rather than gcs().send_text
b6ebed5 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AP_VisualOdom: use GCS_SEND_TEXT rather than gcs().send_text
3b2f11c 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
AR_Motors: use GCS_SEND_TEXT rather than gcs().send_text
915f52a 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
GCS_MAVLink: use GCS_SEND_TEXT rather than gcs().send_text
887ca8e 
Co-authored-by: muramura <[email protected]>
@peterbarker @muramura
SITL: use GCS_SEND_TEXT rather than gcs().send_text
be2b7ed 
Co-authored-by: muramura <[email protected]>
@peterbarker peterbarker mentioned this pull request Aug 7, 2024
Closed
@rmackay9
Copy link
Contributor

rmackay9 commented Aug 7, 2024

This will make it more difficult to backport changes across this line in the code but I still like the change

@MattKear
Copy link
Contributor

MattKear commented Aug 7, 2024

What is the advantage of going to the macro for GCS_SEND_TEXT? I am not challenging the change, just want to understand the advantage 🙂

@rmackay9
Copy link
Contributor

rmackay9 commented Aug 7, 2024

@MattKear,

The only advantage that I'm aware of is that the call disappears on AP_Periph. I like the consistency though even for those libraries that will never be included in AP_Periph

@tridge tridge merged commit e23e58f into ArduPilot:master Aug 7, 2024
93 checks passed
@peterbarker peterbarker deleted the pr/gcs-send-text-replace branch August 9, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peterbarker @rmackay9 @MattKear @tridge @IamPete1