Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GCS_SEND_TEXT in place of gcs().send_text #27776

Merged
merged 24 commits into from
Aug 7, 2024

Conversation

peterbarker
Copy link
Contributor

Replaces #25262

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  -120                                                                  
Durandal                            *      *           *       *                 *      *      *
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           *       *                 *      *      *
MatekF405                           *      *           *       *                 *      *      *
Pixhawk1-1M-bdshot                  *                  *       *                 *      *      *
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           *      *           *       *                 *      *      *
skyviper-v2450                                         *                                       

peterbarker and others added 24 commits August 7, 2024 13:17
@rmackay9
Copy link
Contributor

rmackay9 commented Aug 7, 2024

This will make it more difficult to backport changes across this line in the code but I still like the change

@MattKear
Copy link
Contributor

MattKear commented Aug 7, 2024

What is the advantage of going to the macro for GCS_SEND_TEXT? I am not challenging the change, just want to understand the advantage 🙂

@rmackay9
Copy link
Contributor

rmackay9 commented Aug 7, 2024

@MattKear,

The only advantage that I'm aware of is that the call disappears on AP_Periph. I like the consistency though even for those libraries that will never be included in AP_Periph

@tridge tridge merged commit e23e58f into ArduPilot:master Aug 7, 2024
93 checks passed
@peterbarker peterbarker deleted the pr/gcs-send-text-replace branch August 9, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants