-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for unhandled TKOFF_THR_MAX #27693
Conversation
This makes it safe from my sitl testing... |
Pretty sure this is breaking several Plane autotests. |
@peterbarker I believe the latest commit fixed it. For now I have reverted to the behaviour before #27174. The failing autotests passed locally, but let's see what the CI server says about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we can make min takeoff throttle work for fwd transition
This patches a bug that was introduced via #27174.
It fixes an unhandled case of
TKOFF_THR_MAX=0
, whereTHR_MAX
would not be sourced as a value for the minimum throttle limit during takeoff.The relevant conditions are:
This would result in incorrect backing-off of the minimum throttle during the climb, which @Hwurzburg spotted:
Now it behaves as it should:
Log: https://www.dropbox.com/scl/fi/akdqr9o5niv3qleexh3yd/122221_TakeoffTakeoff4.bin?rlkey=o9uykk6cm7785oxctkj17txxq&dl=0
Side-note:
I notice that there was significant pitch and throttle oscillation in Henry's log.
I don't think this is related to #27174, as the oscillation persists even after TAKEOFF mode has finished climbing, where TECS operates in a regime which I haven't edited.
I believe that a sudden pitch-down and throttle-cut was triggered (because of this bug) during the climb and the default tuning and model physics would yield bad control behaviour.