Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_TECS: Constrained throttle in airspeedless #27452

Closed

Conversation

Georacer
Copy link
Contributor

@Georacer Georacer commented Jul 4, 2024

This is a throwaway PR to highlight that we don't constrain the output throttle limits when in airspeedless TECS mode.

Is there a reason we don't do that? I have observed in simulation that TECS indeed doesn't respect them when configured for airspeedless flight.

@Georacer Georacer marked this pull request as draft July 4, 2024 12:22
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need an AP_TECS API for plane to tell TECS the min and max throttle for the next loop, and the plane code should apply that constraint (so applied in all modes except MANUAL mode) and TECS can be aware of the constraint for integrator handling

@tridge tridge removed the DevCallEU label Jul 17, 2024
@Georacer
Copy link
Contributor Author

Closing as it's integrated in #27174.

@Georacer Georacer closed this Jul 25, 2024
@Georacer Georacer deleted the tecs-airspeedless-throt-limits branch July 25, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants