-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDS: add guided path external control and implement for plane #26339
Open
srmainwaring
wants to merge
8
commits into
ArduPilot:master
Choose a base branch
from
srmainwaring:prs/pr-plane-dds-guided-path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DDS: add guided path external control and implement for plane #26339
srmainwaring
wants to merge
8
commits into
ArduPilot:master
from
srmainwaring:prs/pr-plane-dds-guided-path
+286
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srmainwaring
changed the title
DDS: add guided path support to external control and implement for plane
DDS: add guided path external control and implement for plane
Feb 27, 2024
srmainwaring
force-pushed
the
prs/pr-plane-dds-guided-path
branch
3 times, most recently
from
March 6, 2024 11:06
9f4e088
to
e81395b
Compare
srmainwaring
force-pushed
the
prs/pr-plane-dds-guided-path
branch
3 times, most recently
from
March 12, 2024 21:08
769ee2d
to
cd7a712
Compare
srmainwaring
force-pushed
the
prs/pr-plane-dds-guided-path
branch
from
March 12, 2024 22:20
cd7a712
to
f237983
Compare
srmainwaring
force-pushed
the
prs/pr-plane-dds-guided-path
branch
from
March 13, 2024 08:20
f237983
to
29efcdb
Compare
Ryanf55
reviewed
Oct 28, 2024
} else { | ||
// moving along a line segment - navigate to wp ahead of closest point | ||
// in direction of path tangent | ||
float ofs_m = 100.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be the L1 distance?
https://mercury.kau.ac.kr/park/Archive/PCUAV/gnc_park_deyst_how.pdf
The paper recommends it be configurable.
Signed-off-by: Rhys Mainwaring <[email protected]>
- Implement method update_path - Update comment - Reduce look-ahead distance in update_path Signed-off-by: Rhys Mainwaring <[email protected]>
Signed-off-by: Rhys Mainwaring <[email protected]>
- Add guided path sub-mode - Extend handling of SET_POSITION_TARGET_GLOBAL_INT to include path guidance - Check for non-zero velocity and acceleration - Calculate path curvature and direction - Force update of adjust_altitude_target. - Remove duplicate check for guided mode. Signed-off-by: Rhys Mainwaring <[email protected]>
Signed-off-by: Rhys Mainwaring <[email protected]>
Signed-off-by: Rhys Mainwaring <[email protected]>
…_and_curvature Signed-off-by: Rhys Mainwaring <[email protected]>
- Add guided control. - Update type mask comparisons. - Satisfy codestyle. Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring
force-pushed
the
prs/pr-plane-dds-guided-path
branch
from
October 28, 2024 14:16
29efcdb
to
9c40c52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add guided path external control in DDS and implement for Plane.
Details
set_path_position_tangent_and_curvature
.AP_ExternalControl_Plane
handle_global_position_control
inAP_DDS_External_Control
to handle path guidance setpoint requestsDependencies
The path guidance control for plane depends on the changes in:
Tasks
Testing
Run with a modified version of
terrain_navigation
with the addition of a relay node to forward the mavros GlobalPositionTarget messages onto AP_DDS instead of mavros.Figure: ROS 2 node graph showing setpoint commands from planner forwarded to AP_DDS
Figure: ROS 2 setpoint messages
Figure: rviz view of terrain navigation running via DDS