Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MAVLink receiver support, RADIO_RC_CHANNELS, no II #25838

Closed
wants to merge 3 commits into from

Conversation

olliw42
Copy link
Contributor

@olliw42 olliw42 commented Dec 28, 2023

This PR substitutes #24577.

As compared to the previous PR, there are two changes.

  • the special routing code for the RADIO_RC_CHANNELS message is removed. The RADIO_RC_CHANNELS message in compensation shall have target_system and target_component fields, for routing.
  • the code to bypass the sysid_enforce() check is removed too. This piece of code is not required at this point in time, and it can be either reinserted later when it should be needed or some other mechanism be implemented as needed when needed.

The PR accounts for the concerns with respect to special routing rules and the RADIO_RC_CHANNELS message not having target fields, as discussed in the earlier PR #24577. It accounts for only that part of the discussion however, not also the "heartbeat" thing.

The PR is dependent on ArduPilot/mavlink#343, which brings in the (updated) definition of the RADIO_RC_CHANNELS message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant