Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_DDS: Add instructions for running HW test #25594

Merged

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Nov 22, 2023

Update docs for deploying DDS on hardware like Pixhawk 6X.

Relates to #25535

Copy link
Contributor

@srmainwaring srmainwaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question about mavproxy.py resolving the default connected device, otherwise gtg.

```bash
./waf configure --board Pixhawk6X --enable-dds
./waf plane --upload
mavproxy.py --console
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to specify the device, or is this automatic? On macOS I would have to add --master /dev/cu.usbserial-0001 or similar.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Linux, it's automatic right now with USB.

cd /path/to/ros2_ws
source install/setup.bash
cd src/ardupilot/libraries/AP_DDS
ros2 run micro_ros_agent micro_ros_agent serial -b 115200 -r dds_xrce_profile.xml -D /dev/serial/by-id/usb-ArduPilot_Pixhawk6X_210028000151323131373139-if02
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're assuming that the user has already built the ROS 2 workspace there is also a launch file that may be used to run the micro-ROS agent. We could configure it to find the xrce profile automatically (as it's installed).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, this README is largely from the perspective that you run waf and ros2 run directly rather than launch because of the process isolation and debugging (ie, swapping out micro ROS agent with serial monitor) with what's written today.

The feature to automatically find the xrce profile sounds like a nice addition that could simplify this workflow and still support debugging. Could we add and document that capability in a separate PR?

@magicrub magicrub merged commit 14aeb83 into ArduPilot:master Nov 23, 2023
5 checks passed
@Ryanf55 Ryanf55 deleted the dds-add-hardware-test-instructions branch November 23, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants