Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global: Change numeric and hexadecimal number determination to standard methods #25198

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

muramura
Copy link
Contributor

@muramura muramura commented Oct 7, 2023

I have created my own process to determine the numerical value of a letter, upper case alphabetical letter, and lower case alphabetical letter.
C++ has a standard judgment macro.
Change to the standard judgment macro.
Add a macro to determine if a character is a hexadecimal number.

@peterbarker peterbarker force-pushed the AP_Change_numeric_and_hexadecimal_number_determination_to_standard_methods branch from c267b8d to f817bb8 Compare September 12, 2024 12:43
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is an improvement.

How has this been tested?

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  24                                                                    
Durandal                            24     *           24      24                24     16     16
Hitec-Airspeed           0                                                                     
KakuteH7-bdshot                     0      *           32      32                32     0      -8
MatekF405                           0      *           -8      -8                -8     -8     0
Pixhawk1-1M-bdshot                  0                  -8      -8                0      0      -8
f103-QiotekPeriph        0                                                                     
f303-Universal           -8                                                                    
iomcu                                                                0                         
revo-mini                           0      *           0       -8                -8     -8     -8
skyviper-v2450                                         40                                      

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants