Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Airspeed: Add support for new message #22709

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Conversation

IamPete1
Copy link
Member

This adds support for the new airspeed message. It does not remove the old named value float, maybe we should have them both until we get GCS support.

We need a similar message for baro and then we can remove the three scaled pressure messages.

@IamPete1
Copy link
Member Author

rebased.

libraries/AP_Airspeed/AP_Airspeed.cpp Outdated Show resolved Hide resolved
raw_press : get_differential_pressure(i),
temperature : temperature,
id : i,
flags : (uint8_t)(healthy(i) | (use(i) << 1U))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a flag for primary

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be using an enum from the XML

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now using enum. Not added primary, I would like to get this in without waiting for that.

libraries/GCS_MAVLink/GCS_Common.cpp Outdated Show resolved Hide resolved
libraries/GCS_MAVLink/GCS_Common.cpp Outdated Show resolved Hide resolved
libraries/AP_Airspeed/AP_Airspeed.h Outdated Show resolved Hide resolved
@tridge
Copy link
Contributor

tridge commented Apr 24, 2023

AIRSPEED_SENSOR_FLAGS is not defined in the XML

@IamPete1 IamPete1 force-pushed the airspeed_msg branch 2 times, most recently from ed55bfe to 5611b05 Compare May 1, 2023 00:14
@IamPete1 IamPete1 force-pushed the airspeed_msg branch 2 times, most recently from 2624111 to 7f31bfb Compare May 1, 2023 11:55
@IamPete1 IamPete1 force-pushed the airspeed_msg branch 2 times, most recently from 3b804b9 to 656359c Compare December 1, 2023 15:02
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not forget this one!

libraries/AP_Airspeed/AP_Airspeed.cpp Outdated Show resolved Hide resolved
libraries/GCS_MAVLink/GCS_Common.cpp Outdated Show resolved Hide resolved
libraries/AP_Airspeed/AP_Airspeed.h Outdated Show resolved Hide resolved
@IamPete1
Copy link
Member Author

IamPete1 commented Sep 11, 2024

Rebased and moved sending from airspeed lib to GCS MAVLINK. Tested manually that we get the message and it cycles through sensors.

@tridge tridge dismissed stale reviews from WickedShell and peterbarker September 16, 2024 23:09

fixed

@tridge tridge merged commit 8318109 into ArduPilot:master Sep 16, 2024
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants