HardwareReport: Added GPS #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
requested changes
Apr 8, 2024
IamPete1
reviewed
Apr 17, 2024
|
I have reworked your commits a little to remove some console prints and unrelated changes. I then squashed your commits into one. I then did a little fixup because it was erroring out if the regexs were failing, just needed to check they worked before using the result. I then did fix for the new param names that have just gone into 4.6 and a added printing of the type param and the drone can device name. Now look like this:
Thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@IamPete1 I have added the GPS sections in the page for this issue #72 . Please have a look, if it needs any change.