-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deb builder for ArduPilot version #3
base: master
Are you sure you want to change the base?
Conversation
59aa0e0
to
af4438e
Compare
af4438e
to
8a8de45
Compare
Nice! Should this go upstream? They already build debs. |
@@ -0,0 +1,12 @@ | |||
Package: ap-microxrceddsgen | |||
Version: 0.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally,this matches the version of the tool. Currently, it's not set, but official releases will have a version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, we can update this one, when you use the build script it update the Version to the right one's
echo "Usage: $0 <version>" | ||
exit 1 | ||
fi | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set -euf -o pipefail | |
Catch errors earlier with this protection in shell.
|
||
- uses: ./src/microxrceddsgen/.github/actions/install-apt-packages | ||
|
||
- name: Get minimum supported version of CMake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually need cmake to build it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied the current ci rules, I think it is used for the test as it download dds clients
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- uses: actions/checkout@v3 | |
- uses: actions/checkout@v4 |
v3 is EOL soon I think
@khancyr Got any time to finish this up? It's really great. |
A great next step would be to put this on an apt repo so we can have people |
add a simple way to create a deb file for the generator
also add a release build workflow. To trigger it, just create a github release with a tag and it will build the deb and put it as release artefact